Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.17.1 #3627

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Update to Go 1.17.1 #3627

merged 2 commits into from
Oct 14, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Update Go to 1.17.1 in operator, executor and core-builder

Which issue(s) this PR fixes:

Fixes #3533

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@ukclivecox
Copy link
Contributor Author

/test release

1 similar comment
@axsaucedo
Copy link
Contributor

/test release

@ukclivecox
Copy link
Contributor Author

/test release

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

seldondev commented Oct 5, 2021 •
edited
Loading

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
release-build-push 41244b5 link /test release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

All tests pass - looks good, merging
image

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit 427ed9f into SeldonIO:master Oct 14, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@ukclivecox
Update to Go 1.17.1 (SeldonIO#3627)
525792d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Go to 1.17
3 participants
@ukclivecox @axsaucedo @seldondev