Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor Returns Clearer Errors on HTTP Failures #3626

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Executor Returns Clearer Errors on HTTP Failures #3626

merged 4 commits into from
Oct 26, 2021

Conversation

mwm5945
Copy link
Contributor

@mwm5945 mwm5945 commented Sep 30, 2021

What this PR does / why we need it:
The executor will now format an HTTP error into a Seldon Message and return it in the body of the response.

Which issue(s) this PR fixes:

Fixes #3625

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

executor returns clearer http failure error messages

@seldondev
Copy link
Collaborator

Hi @mwm5945. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@mwm5945 mwm5945 closed this Sep 30, 2021
@mwm5945 mwm5945 reopened this Sep 30, 2021
@seldondev seldondev added size/M and removed size/XS labels Sep 30, 2021
@mwm5945
Copy link
Contributor Author

mwm5945 commented Sep 30, 2021

/assign @cliveseldon @axsaucedo

@axsaucedo axsaucedo self-requested a review October 14, 2021 12:57
@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 530bab0 into SeldonIO:master Oct 26, 2021
@mwm5945 mwm5945 deleted the executor-http-errs branch November 4, 2021 13:40
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@mwm5945
Executor Returns Clearer Errors on HTTP Failures (SeldonIO#3626)
ce493c7 
* set http error in response payload from executor

* set http error in response payload from executor

* fix tests, check for error type

* add status to rest error response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees

@axsaucedo axsaucedo

@ukclivecox ukclivecox

Labels
approved needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executor returns minimal information on http client failure
4 participants
@mwm5945 @seldondev @ukclivecox @axsaucedo