Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note on SO_REUSEPORT requirement #3593

Merged
merged 1 commit into from
Sep 17, 2021
Merged

add note on SO_REUSEPORT requirement #3593

merged 1 commit into from
Sep 17, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Sep 16, 2021

What this PR does / why we need it:

Add note on AttributeError: module 'socket' has no attribute 'SO_REUSEPORT' to the upgrading page.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Difficult to establish universal minimum version requirements. For example for 3.8.x line it does not work with <3.8.5, works fine with 3.8.5 and 3.8.6. Couldn't test with 3.8.7 as there was no anaconda package, then was broken for 3.8.8 and fixed again for 3.8.10 for example. But this can actually lie in the compilation problem of the python itself so version compatibility is difficult to establish.

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit 0699f0b into SeldonIO:master Sep 17, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants