Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python38 as default #3591

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Python38 as default #3591

merged 4 commits into from
Sep 20, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3500

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

One integration failure on test_rolling_deployment[graph1.json-graph2.json-True-ambas]
/test integration

@RafalSkolasinski
Copy link
Contributor Author

Integration failures on:

  • TestPrepack.test_xgboost_v2
  • TestPrepack.test_mlflow_v2

@RafalSkolasinski
Copy link
Contributor Author

Notebook failure:

  • TestNotebooks.test_explainer_examples

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test integration

agrski
agrski approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafalSkolasinski
Copy link
Contributor Author

we do have successful notebook pass
image

@RafalSkolasinski
Copy link
Contributor Author

integration failures on:

  • test_rolling_deployment[graph1.json-graph4.json-True-ambas]
  • TestPrepack.test_mlflow_v2
  • TestPrepack.test_xgboost_v2

@RafalSkolasinski
Copy link
Contributor Author

/test integration

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

Verified locally prepack tests. They pass without issues and further on they cannot be broken by this change as these servers are based on ...-ubi8 images with specify explicitly python versions with ...-python37-ubi8.
image

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

Tested the rolling updates locally, everything green:
image

Also worth to mention that test_rolling_deployment[graph1.json-graph4.json-True-ambas] is testing seldonio/fixed-model:0.1 update from engine to executor deployment and the fixed model image is build with:

	s2i build -E environment_v1 . seldonio/seldon-core-s2i-python37-ubi8:${VERSION} seldonio/fixed-model:0.1
	s2i build -E environment_v2 . seldonio/seldon-core-s2i-python37-ubi8:${VERSION}  seldonio/fixed-model:0.2

so not yet affected by current changes.

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski RafalSkolasinski mentioned this pull request Sep 17, 2021
Closed
@axsaucedo
Copy link
Contributor

Nice one - looks good
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agrski, axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 0d0c826 into SeldonIO:master Sep 20, 2021
axsaucedo added a commit to axsaucedo/seldon-core that referenced this pull request Sep 21, 2021
@axsaucedo
Revert "Python38 as default (SeldonIO#3591)"
2658cdb 
This reverts commit 0d0c826.
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@RafalSkolasinski @agrski
Python38 as default (SeldonIO#3591)
5264dbb 
* make pyhon 3.8 default

* add ugprading note

* Update doc/source/reference/images.md

Co-authored-by: Alex Rakowski <[email protected]>

* Update images.md

Co-authored-by: Alex Rakowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrski agrski agrski approved these changes

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Python 3.8 s2i wrapper the default one
4 participants
@RafalSkolasinski @axsaucedo @seldondev @agrski