-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transmit event key from input topic to output topic in kafka #3578
Conversation
Hi @eastmon94. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test notebooks |
/test integration |
Thanks @eastmon94 can you explain in a bit more detail the addition. Are you saying your Kafka rejects new messages without a given request or you need to ensure it keeps the same Key? |
Thanks @cliveseldon. There are cases where a key is needed when using the message received in the output topic as input. In my case, the result of the model should be post-processed with Beam and Flink, but in the case of the 'ReadFromKafka' operation, the key must be included in the message. So, I tried to simply pass the key entered in the input topic to the output topic. |
/test integration |
1 similar comment
/test integration |
/test notebooks |
/test integration |
3 similar comments
/test integration |
/test integration |
/test integration |
@eastmon94 Thanks! |
What this PR does / why we need it:
When doing stream serving with Kafka, we cannot receive event keys although it is required.
So we just need to send the event key from input topic to output topic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: