Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmit event key from input topic to output topic in kafka #3578

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

eastmon94
Copy link
Contributor

What this PR does / why we need it:
When doing stream serving with Kafka, we cannot receive event keys although it is required.
So we just need to send the event key from input topic to output topic.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Hi @eastmon94. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test notebooks

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

Thanks @eastmon94 can you explain in a bit more detail the addition. Are you saying your Kafka rejects new messages without a given request or you need to ensure it keeps the same Key?

@eastmon94
Copy link
Contributor Author

eastmon94 commented Sep 9, 2021

Thanks @cliveseldon. There are cases where a key is needed when using the message received in the output topic as input. In my case, the result of the model should be post-processed with Beam and Flink, but in the case of the 'ReadFromKafka' operation, the key must be included in the message. So, I tried to simply pass the key entered in the input topic to the output topic.

@ukclivecox
Copy link
Contributor

/test integration

1 similar comment
@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/test notebooks

@ukclivecox
Copy link
Contributor

/test integration

3 similar comments
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test integration

@ukclivecox ukclivecox merged commit ab1868b into SeldonIO:master Sep 15, 2021
@ukclivecox
Copy link
Contributor

@eastmon94 Thanks!

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants