Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user customize LeaderElectionID #3577

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Sep 8, 2021

What this PR does / why we need it:
Right now LeaderElectionID is hardcoded, this will cause issue if we run side-by-side seldon-core operator.

Which issue(s) this PR fixes:

Fixes #3576

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test notebooks

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

@anggao All looks good to me - lets just run the tests.

@ukclivecox ukclivecox merged commit c5f9904 into SeldonIO:master Sep 9, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
* Allow user customize LeaderElectionID

* Allow user customize LeaderElectionID - helm changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should allow user customize LeaderElectionID
3 participants