Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kind #3571

Merged
merged 8 commits into from
Sep 7, 2021
Merged

Update kind #3571

merged 8 commits into from
Sep 7, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2966
Fixes #3357

Supersedes: #3383

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft September 6, 2021 10:41
@seldondev seldondev added size/M and removed size/S labels Sep 6, 2021
@RafalSkolasinski
Copy link
Contributor Author

/retest

@RafalSkolasinski
Copy link
Contributor Author

/test this

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review September 6, 2021 16:42
@RafalSkolasinski
Copy link
Contributor Author

tests have passed in the CI, the pushed commit does not affect tests
image

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/retest

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3571]: [Not Found]

2 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3571]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3571]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3571]: [Method Not Allowed]

@RafalSkolasinski RafalSkolasinski merged commit d1c29f0 into SeldonIO:master Sep 7, 2021
@axsaucedo axsaucedo mentioned this pull request Sep 8, 2021
Closed
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@RafalSkolasinski @axsaucedo
Update kind (SeldonIO#3571)
cb14f81 
* Updated core builder image

* Updated core builder image

* Updating kind of kind

* Dropped operator upgrades before 1.2.3

* Updated to start at 1.3.0

* update core-builder tag to 0.25

* fix kubebuilder installation in core-builder

* extend update tests

Co-authored-by: Alejandro Saucedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved size/M
Projects
None yet
Milestone
No milestone
3 participants
@RafalSkolasinski @axsaucedo @seldondev