Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build alibi explain server using poetry #3549

Merged
merged 5 commits into from
Oct 4, 2021
Merged

build alibi explain server using poetry #3549

merged 5 commits into from
Oct 4, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

A step towards #2584.
This introduces fully locked dependency for building alibi explain server image.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft August 27, 2021 20:38
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

So far integration failures:

Run 5:

  • TestPrepack.test_mlflow_v2

Run 3:

  • test_rolling_deployment[graph1.json-graph2.json-True-ambas]
  • TestPrepack.test_mlflow_v2

@RafalSkolasinski
Copy link
Contributor Author

image

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review October 1, 2021 16:00
@RafalSkolasinski RafalSkolasinski changed the title WIP: build alibi explain server using poetry build alibi explain server using poetry Oct 1, 2021
axsaucedo
axsaucedo reviewed Oct 4, 2021
View reviewed changes
components/alibi-explain-server/Dockerfile
LABEL name="Seldon Alibi Wrapper" \
vendor="Seldon Technologies" \
version="1.12.0-dev" \
version="$VERSION" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you validate that this won't just be replaced by the release script? I think for several docker files this is what has basically led to the version being hardcoded

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3549]: [Not Found]

@axsaucedo axsaucedo merged commit bf764b2 into SeldonIO:master Oct 4, 2021
@seldondev seldondev mentioned this pull request Oct 11, 2021
Closed
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@RafalSkolasinski
build alibi explain server using poetry (SeldonIO#3549)
3fa7fd3 
* WIP: build alibi explain server using poetry

* update poetry work on alibi explain server

* add poetry to python builder

* upgrade

* upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo left review comments

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafalSkolasinski @axsaucedo @seldondev