Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a first pass mlflow v2 end to end example #3483

Merged
merged 10 commits into from
Aug 12, 2021
Merged

Add a first pass mlflow v2 end to end example #3483

merged 10 commits into from
Aug 12, 2021

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Aug 11, 2021

What this PR does / why we need it:
Adds a notebook to showcase building a model using mlflow, pack and deploy in seldon-core (local kind cluster)

Which issue(s) this PR fixes:

Fixes #3479

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,902 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOrmally we have the "seldon core setup" as a link to the main docs, you could reuse the same description as in the minio example


Reply via ReviewNB

@@ -0,0 +1,902 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to clear this cell if left here


Reply via ReviewNB

@@ -0,0 +1,902 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add subtitels to these sections as well


Reply via ReviewNB

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments - also a couple of extra things required to move around:

  • Rename notebook to README.pynb
  • Convert readme to markdown so people accessing from github can read it as well

fix licenses

fix licenses 2

no licenses manually
@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 99e1b38 into SeldonIO:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an end-2-end notebook example for v2 mlflow model serving
3 participants