Auto set GOMAXPROCS based on container limits in executor and operator #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration |
|
/test notebooks |
ivan-valkov
force-pushed
the
auto-gomaxprocs
branch
from
701fa92 to
dad322f
Compare
stephen37
pushed a commit
to stephen37/seldon-core
that referenced
this pull request
Dec 21, 2021
SeldonIO#3471) * Auto set GOMAXPROCS based on container limits in executor and operator * fix licences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The default value of GOMAXPROCS is based on all visible CPUs by the go process (golang/go#33803). In k8s this will be all CPUs available on the node. This is a problem because - if we set a limit on the container, GOMAXPROCS will not respect that. This will result in throttling because we won't be able to use all resources we think we can use.
Which issue(s) this PR fixes:
Fixes #3468
Special notes for your reviewer:
Does this PR introduce a user-facing change?: