Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assertion #3443

Merged
merged 3 commits into from
Aug 2, 2021
Merged

remove assertion #3443

merged 3 commits into from
Aug 2, 2021

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Jul 30, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@sakoush
Copy link
Member Author

sakoush commented Jul 30, 2021

/test integration

@RafalSkolasinski RafalSkolasinski self-requested a review July 30, 2021 14:55
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sakoush
Copy link
Member Author

sakoush commented Jul 30, 2021

/test integration

1 similar comment
@sakoush
Copy link
Member Author

sakoush commented Aug 2, 2021

/test integration

@sakoush
Copy link
Member Author

sakoush commented Aug 2, 2021

/test integration

@seldondev seldondev merged commit 22d19a1 into SeldonIO:master Aug 2, 2021
seldondev pushed a commit that referenced this pull request Aug 3, 2021
* Add MLFlow MLServer support (v2 protocol)

* add test

* dummy image

* use 0.4.0.dev1 docker images for mlflow v2

* add integration test for mlflow v2

* fix formatting issues

* add mlflow v2 doc

* update protocols.md to reflect MlFlow v2 support

* fix docs

* update doc

* Adding instructions for migration of Kubernetes post 1.18 (#3444)

* Update upgrading.md

* Update upgrading.md

* Update upgrading.md

* remove assertion (#3443)

* remove assertion

* add a note in the Makefile

* add a note in test

Co-authored-by: Sherif Akoush <[email protected]>

Co-authored-by: Sherif Akoush <[email protected]>
Co-authored-by: Alejandro Saucedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants