Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMP AFFINITY benchmark and docs for production optimization #3434

Merged
merged 8 commits into from
Jul 29, 2021
Merged

KMP AFFINITY benchmark and docs for production optimization #3434

merged 8 commits into from
Jul 29, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Adds KMP_AFFINITY notebook
  • Adds documentation on production optimization

Which issue(s) this PR fixes:

Fixes #931

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor

/hold

@axsaucedo
Copy link
Contributor

I had approved but just realised something that has happeend to me before (which is a bit annoying) is failing in the docs test, namely:

/__w/seldon-core/seldon-core/doc/source/examples/notebooks.rst:179: WARNING: toctree contains reference to nonexisting document 'examples/python_kmp_affinity'

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit b1d2c1d into SeldonIO:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latency performance of python microservice with thread affinity
3 participants