Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build new iris model as gs://seldon-models/v1.10.0-dev/sklearn/iris (and moviesentiment) #3425

Merged
merged 17 commits into from
Jul 27, 2021
Merged

build new iris model as gs://seldon-models/v1.10.0-dev/sklearn/iris (and moviesentiment) #3425

merged 17 commits into from
Jul 27, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 23, 2021 •
edited
Loading

What this PR does / why we need it:

Because we recently updated version of Scikit Learn in seldonio/sklearnserver we also need to update the iris model we use in our examples.

Which issue(s) this PR fixes:

Closes #3424

Special notes for your reviewer:

This uses iris model build especially for this release gs://seldon-models/v1.10.0-dev/sklearn/iris and adds Makefile that trains and uploads model as required.

Note: this now also includes:

  • gs://seldon-models/v1.10.0-dev/sklear/moviesentiment
  • gs://seldon-models/v1.10.0-dev/mlflow/elasticnet_wine

Does this PR introduce a user-facing change?:

From SC 1.10.0 certain models will be versioned for each SC release.. This PR adds:
- gs://seldon-models/v1.10.0-dev/sklearn/iris
- gs://seldon-models/v1.10.0-dev/sklear/moviesentiment
- gs://seldon-models/v1.10.0-dev/mlflow/elasticnet_wine

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski RafalSkolasinski marked this pull request as draft July 23, 2021 14:18
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev seldondev added size/XL and removed size/L labels Jul 23, 2021
@RafalSkolasinski RafalSkolasinski changed the title build new iris model as gs://seldon-models/v1.10.0-dev/sklearn/iris build new iris model as gs://seldon-models/v1.10.0-dev/sklearn/iris (and moviesentiment) Jul 23, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev seldondev removed the size/XL label Jul 26, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

With latest changes to this time the integration tests are passing

image

And two notebook tests are failing

  • TestNotebooks.test_server_examples
  • TestNotebooks.test_upgrade

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev seldondev added size/XXL and removed size/L labels Jul 26, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Jul 27, 2021 •
edited
Loading

Triggered integration once again, just for completeness.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review July 27, 2021 14:01
@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 224d060 into SeldonIO:master Jul 27, 2021
This was referenced Jul 27, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sklearn iris model incompatible with latest sklearnserver (1.10.0-dev)
3 participants
@RafalSkolasinski @axsaucedo @seldondev