Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix push of conda base image #3406

Merged
merged 4 commits into from
Jul 19, 2021
Merged

fix push of conda base image #3406

merged 4 commits into from
Jul 19, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 14, 2021

What this PR does / why we need it:

  • fixes push of conda base image: seldonio/conda-ubi8
  • makes sure that specified version of conda is used in derived images
  • remove Dockerfile.redhat as at this point it is the same as Dockerfile.local

Which issue(s) this PR fixes:

Closes #3405
Closes #3115

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft July 14, 2021 15:32
@RafalSkolasinski
Copy link
Contributor Author

/test release

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor Author

Licence lint is fixed in #3404

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

Notebook and integration tests have already passed.
Just rebased onto master to include lint fixes.
Triggering tests again for completness.

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

Failure on TestNotebooks.test_server_examples that didn't happen before.
Triggering again

/test notebooks

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
release-build-push 05c29ef link /test release
notebooks ab74a69 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo axsaucedo merged commit 1fe87a2 into SeldonIO:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda base image is not being pushed to docker hub wrong conda version used in the mlflowserver image
3 participants