Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updates to push 0.4.2 java wrapper #3392

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Added updates to push 0.4.2 java wrapper #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion incubating/wrappers/java/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
SELDON_CORE_DIR=../../..
IMAGE_NAME=seldon-java-wrapper
VERSION := $(shell cat ../version.txt)
VERSION := $(shell cat ../../../version.txt)

version:
echo ${VERSION}
Expand Down
6 changes: 3 additions & 3 deletions incubating/wrappers/java/src/main/java/io/seldon/wrapper/api/ModelPredictionController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ public class ModelPredictionController {
* Will accept a POST or a GET request with either a query parameter or a FORM parameter.
*
* Examples:
* GET -> /predict?json={ ... }
* GET - /predict?json={ ... }
* curl -s \
* localhost:9000/predict?json={"data": {"names": ["a", "b"], "ndarray": [[1.0, 2.0]]}}' \
*
* POST FORM -> /predict
* POST FORM - /predict
* curl -s -X POST \
* -d 'json={"data": {"names": ["a", "b"], "ndarray": [[1.0, 2.0]]}}' \
* localhost:9000/predict
Expand All @@ -62,7 +62,7 @@ public ResponseEntity<String> predictLegacy(@RequestParam("json") String json) {
* Will accept a POST with a proper JSON body.
*
* Examples:
* POST -> /predict
* POST - /predict
* curl -s -X POST \
* -d '{"data": {"names": ["a", "b"], "ndarray": [[1.0, 2.0]]}}' \
* localhost:9000/predict
Expand Down
2 changes: 1 addition & 1 deletion incubating/wrappers/java/src/test/java/io/seldon/wrapper/grpc/GrpcServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public void predictTest() throws IOException {
ArgumentCaptor<SeldonMessage> argument = ArgumentCaptor.forClass(SeldonMessage.class);
verify(responseObserver).onNext(argument.capture());
SeldonMessage response = argument.getAllValues().get(0);
Assert.assertEquals(1, response.getData().getTensor().getValuesCount());
Assert.assertEquals(0, response.getData().getTensor().getValuesCount());
}

@Test
Expand Down