-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include seldon-puid in grpc headers #3390
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test integration |
/test notebooks |
/test notebooks |
@RafalSkolasinski looks good - we should also validate whether we should add this on the kfserving grpc server flow |
Yes we should. |
Just added commit with it. |
/test notebooks |
/test integration |
All notebooks and integrations tests pass, as well as lint - docs test/lint will have to be addressed in separate pr as also faling in master |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Closes #3389
Closes #3386
Special notes for your reviewer:
Does this PR introduce a user-facing change?: