Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include seldon-puid in grpc headers #3390

Merged
merged 7 commits into from
Jul 12, 2021
Merged

include seldon-puid in grpc headers #3390

merged 7 commits into from
Jul 12, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 9, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Closes #3389
Closes #3386

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

@RafalSkolasinski looks good - we should also validate whether we should add this on the kfserving grpc server flow

@ukclivecox
Copy link
Contributor

@RafalSkolasinski looks good - we should also validate whether we should add this on the kfserving grpc server flow

Yes we should.

@RafalSkolasinski
Copy link
Contributor Author

@RafalSkolasinski looks good - we should also validate whether we should add this on the kfserving grpc server flow

Yes we should.

Just added commit with it.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

image

@axsaucedo
Copy link
Contributor

All notebooks and integrations tests pass, as well as lint - docs test/lint will have to be addressed in separate pr as also faling in master
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 78fbe31 into SeldonIO:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seldon-puid not included in grpc requests Docs lint is failing due to argo moving repo
4 participants