Fix tags propogation with seldon client #3374
Conversation
|
/test integration |
1 similar comment
|
/test integration |
|
Nice one |
| raise RuntimeError( | ||
| "Only `ndarray` and `tensor` input are currently supported for batch size greater than 1." | ||
| ) | ||
| except Exception as e: |
There was a problem hiding this comment.
Not clear what exception are we trying to caught here
There was a problem hiding this comment.
But looking at other parts of code they follow same pattern so I guess it is okay for now.
| @@ -267,7 +267,7 @@ def _send_batch_predict_multi_request( | |||
| retries: int, | |||
| batch_id: str, | |||
| payload_type: str, | |||
| ) -> str: | |||
| ) -> [str]: | |||
There was a problem hiding this comment.
Is this coming from lint?
There was a problem hiding this comment.
No it was a warning from my IDE
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I discovered two small bugs in the seldon client when testing the batch processor.
["meta"]["tags"]["tags"]seldonnotistio