Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example upgrade path into rclone-based storage initializer #3342

Merged
merged 3 commits into from
Jun 30, 2021
Merged

add example upgrade path into rclone-based storage initializer #3342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c515a8
add example upgrade path into rclone-based storage initializer
RafalSkolasinski Jun 28, 2021
7d9920b
add example of automated upgrade of secrets and service accounts
RafalSkolasinski Jun 29, 2021
5d6965a
add more comments
RafalSkolasinski Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/source/examples/global-rclone-upgrade.nblink
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"path": "../../../examples/upgrade-to-rclone/global-rclone-upgrade.ipynb"
}
3 changes: 3 additions & 0 deletions doc/source/examples/rclone-upgrade.nblink
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"path": "../../../examples/upgrade-to-rclone/rclone-upgrade.ipynb"
}
5 changes: 4 additions & 1 deletion doc/source/reference/upgrading.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ storageInitializer:
```
and can be customised on per-deployment basis as described in [Prepackaged Model Servers](../servers/overview.md) documentation by setting value of `storageInitializerImage` variable in the graph definition.

This transition requires **creation of the new secrets** for the prepackaged model servers that will be compatible with the rclone configuration format as described [here](../servers/overview.md#handling-credentials).
This transition requires **creation of the new secrets** for the prepackaged model servers that will be compatible with the rclone configuration format as described [here](../servers/overview.md#handling-credentials). Read more:

- [How to test new secret format](../examples/rclone-upgrade.html)
- [Example cluster upgrade for AWS/MinIO configuration](../examples/global-rclone-upgrade.html)

If you do not wish to configure these secrets now and wish to preserve prior behaviour you can opt for usage of previous storage initializer by using following helm value:
```yaml
Expand Down
2 changes: 1 addition & 1 deletion doc/source/servers/kfserving-storage-initializer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ storageInitializer:
image: gcr.io/kfserving/storage-initializer:v0.4.0
```

Current behaviour is described [here](./overview.md).
> :warning: **NOTE:** Current default storage initializer is `seldonio/rclone-storage-initializer:1.10.0-dev` is described [here](./overview.md).


When `kfserving/storage-initializer` is used `modeluri` supports the following four object storage providers:
Expand Down
17 changes: 17 additions & 0 deletions doc/source/servers/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,23 @@ stringData:
RCLONE_CONFIG_S3_ENDPOINT: http://minio.minio-system.svc.cluster.local:9000
```

### Example AWS S3 with access key and secret

Reference: [rclone documentation](https://rclone.org/s3/#amazon-s3)

```yaml
apiVersion: v1
kind: Secret
metadata:
name: seldon-rclone-secret
type: Opaque
stringData:
RCLONE_CONFIG_S3_TYPE: s3
RCLONE_CONFIG_S3_PROVIDER: aws
RCLONE_CONFIG_S3_ENV_AUTH: "false"
RCLONE_CONFIG_S3_ACCESS_KEY_ID: "<your AWS_ACCESS_KEY_ID here>"
RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "<your AWS_SECRET_ACCESS_KEY here>"
```


### Example AWS S3 with IAM roles configuration
Expand Down
2 changes: 1 addition & 1 deletion examples/init_containers/custom_init_container.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.9"
"version": "3.7.10"
}
},
"nbformat": 4,
Expand Down
Loading