-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking automation with on-demand CI test #3335
Benchmarking automation with on-demand CI test #3335
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test benchmark |
/test benchmark |
/test benchmark |
/test benchmark |
/test benchmark |
/test benchmark |
1 similar comment
/test benchmark |
/test benchmark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
||
- name: run-benchmark-iteration-step-template | ||
inputs: | ||
parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think listing the parameters here again is required - I have the feeling these can be just listed once globally for the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately it is needed, each of the sections is like a "function", so you have to define the arguemnts, and then pass them, at every level
@@ -0,0 +1,495 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,495 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #11. --set seldonDeployment.apiType="rest|grpc" \
If the value is defined as A|B
will it then create two workflows?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, you can define mutliple values and it will generate all the different combinations and run the equivallent number of jobs
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test benchmark |
/test benchmark |
Benchmark results
|
/test benchmark |
Benchmark results
|
/test benchmark |
/test benchmark |
/test benchmark |
2 similar comments
/test benchmark |
/test benchmark |
/test benchmark |
/test benchmark |
Benchmark results
|
This PR contains:
Link to sample comment: #3335 (comment)
Some context pieces to consider:
Outstanding work [to be done in separate PR]: