-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added doc hint for install behind proxy #3311
Conversation
Hi @bmfisher. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - I added a comment to move to bottom but other than that look great. Thanks for the contribution.
doc/source/workflow/install.md
Outdated
@@ -77,6 +77,18 @@ helm install seldon-core seldon-core-operator \ | |||
--set certManager.enabled=true | |||
``` | |||
|
|||
### Install behind a proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good - given how specific this is may be best to append this section at the end of the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axsaucedo updated
/assign @gsunner |
Thanks @bmfisher |
What this PR does / why we need it:
Adds a doc hint / troubleshooting aid for users installing Seldon on a kubernetes cluster behind a proxy.
Does this PR introduce a user-facing change?: