Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc hint for install behind proxy #3311

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

bmfisher
Copy link
Contributor

What this PR does / why we need it:
Adds a doc hint / troubleshooting aid for users installing Seldon on a kubernetes cluster behind a proxy.

Does this PR introduce a user-facing change?:

Added doc hint for install behind proxy

@seldondev
Copy link
Collaborator

Hi @bmfisher. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gsunner
You can assign the PR to them by writing /assign @gsunner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I added a comment to move to bottom but other than that look great. Thanks for the contribution.

@@ -77,6 +77,18 @@ helm install seldon-core seldon-core-operator \
--set certManager.enabled=true
```

### Install behind a proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good - given how specific this is may be best to append this section at the end of the doc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axsaucedo updated

@bmfisher
Copy link
Contributor Author

/assign @gsunner

@ukclivecox
Copy link
Contributor

Thanks @bmfisher

@ukclivecox ukclivecox merged commit ab12736 into SeldonIO:master Jun 21, 2021
@bmfisher bmfisher deleted the docs-add-proxy-hint branch June 21, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants