Micro batch followup #3306
Merged
Micro batch followup #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data = json.loads(raw_data[2]) | ||
| data_np = np.array(data) | ||
| concat = np.concatenate((concat, data_np)) | ||
| loaded = [json.loads(raw_data[2]) for raw_data in input_data] |
There was a problem hiding this comment.
Nice one, looks much better!
RafalSkolasinski
approved these changes
Jun 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration |
|
Another thing I would add is perhaps expanding on the documentation for mini-batching (thre is a batch processing section in the docs) |
|
@axsaucedo I did that in the last PR, added docs about it 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying and some small adjustments after the last PR was automerged.