elements for batch and tf protocol #3280
Conversation
| @@ -135,11 +135,19 @@ def process_and_update_elastic_doc( | |||
|
|
|||
| no_items_in_batch = len(new_content_part["instance"]) | |||
| index = 0 | |||
| for item in new_content_part["instance"]: | |||
| elements = None | |||
There was a problem hiding this comment.
this was just iterating through the instances in case of batch... now we need to iterate through instances and find corresponding 'elements' for each but only if there are elements (might not be if there are no names and no schema)
| namespace = log_helper.get_header(log_helper.NAMESPACE_HEADER_NAME, headers) | ||
| inferenceservice_name = log_helper.get_header(log_helper.INFERENCESERVICE_HEADER_NAME, headers) | ||
| endpoint_name = log_helper.get_header(log_helper.ENDPOINT_HEADER_NAME, headers) | ||
| serving_engine = log_helper.serving_engine(headers) |
There was a problem hiding this comment.
moving this up so it can be used across the code for different protocols
| i, requestMsg, req_datatype, req_features, req_datadef | ||
| ) | ||
| reqJson["elements"] = e | ||
| copy = reqJson |
There was a problem hiding this comment.
this code to iterate elements is replaced by the new logic at line 138
|
|
||
| item_body = doc_body.copy() | ||
|
|
||
| item_body[message_type]["instance"] = item | ||
|
|
||
| if type(elements) == type([]) and len(elements) >= num: |
There was a problem hiding this comment.
what is this condition for length >= num?
There was a problem hiding this comment.
Oh, I think it should be >. It is checking that elements array contains an entry at this index. So if at index 2 then elements needs to be of length of at least three. I will try changing it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SachinVarghese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #3279