Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some unit tests for req logger #3271

Merged
merged 2 commits into from
Jun 7, 2021
Merged

some unit tests for req logger #3271

merged 2 commits into from
Jun 7, 2021

Conversation

ryandawsonuk
Copy link
Contributor

fixes #3270

@ryandawsonuk ryandawsonuk changed the title 3270 unit test req logger some unit tests for req logger Jun 7, 2021
SachinVarghese
SachinVarghese reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 547d083 into SeldonIO:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachinVarghese SachinVarghese SachinVarghese left review comments

Assignees
No one assigned
Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add some unit tests for request logger
3 participants
@ryandawsonuk @seldondev @SachinVarghese