Add kfserving protocol to alibi explainer server #3248
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test notebooks |
ukclivecox
requested review from
RafalSkolasinski
and removed request for
axsaucedo
|
|
||
| class Protocol(Enum): | ||
| tensorflow_http = "tensorflow.http" | ||
| seldon_http = "seldon.http" | ||
| seldon_grpc = "seldon.grpc" | ||
| v2_http = "kfserving.http" |
There was a problem hiding this comment.
Just wondering for consistency whether we should call it kfserving everywhere - I guess later on we may do a full on refactor to just rename it to v2 everywhere
| class KFServingV2RequestHandler(): | ||
|
|
||
| def extract_request(self, request: Dict) -> List: | ||
| inputs = request["inputs"][0] |
There was a problem hiding this comment.
This would fail if it's empty, but I guess I can't think of a situation where we'd want to log empty request
| if arr.dtype in _nptymap: | ||
| return { | ||
| "name": name, | ||
| "datatype": ty, |
There was a problem hiding this comment.
Is there any validation required for the type?
|
I added a couple of comments but other than that looks good 👍 |
|
/test integration |
|
/test notebooks |
1 similar comment
|
/test notebooks |
|
/test integration |
1 similar comment
|
/test integration |
|
Merging |
|
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3247
Special notes for your reviewer:
Does this PR introduce a user-facing change?: