Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explainer replicas and handle scale to zero #3246

Merged
merged 4 commits into from
Jun 5, 2021
Merged

Add explainer replicas and handle scale to zero #3246

merged 4 commits into from
Jun 5, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Scales explainer to zero if main predictor replicas is zero
  • Allows explainer replicas to be add. New addition to CRD.

Which issue(s) this PR fixes:

Fixes #3241

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo May 28, 2021 18:40
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor

Added a suggestion on test, but other than that looks good

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor

/test integration

2 similar comments
@ukclivecox
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

Merge conflict needs to be resolved to rerun tests

@axsaucedo
Copy link
Contributor

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

Notebooks and integration tests pass, and all comments resolved, merging
image

@axsaucedo axsaucedo merged commit 33554d7 into SeldonIO:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explainer don't repect the spec.replicas
3 participants