-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tfserving proxy custom data #3209
Tfserving proxy custom data #3209
Conversation
Hi @sebov. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @SachinVarghese |
/ok-to-test |
/test all |
/test release |
@sebov: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Hi @cliveseldon. May I ask what happened in this PR? It would be a great help for my future contributions. I can see that one of the test "release-build-push" failed for commit "d35d48c". I cannot see the details (there is a login popup when clicked on the link), however this particular commit was concerned only the code reformatting by "black" code formatter - like described on your site https://docs.seldon.io/projects/seldon-core/en/v1.1.0/developer/contributing.html and in .pre-commit-config.yaml. |
Tfserving proxy custom data
What this PR does / why we need it:
Currently there is no way to handle multiple input/output tensors for the model using Tensorflow Prepackaged Model Server. This PR enables the use of custom_data to pass and receive Tensorflow's predict_pb2.PredictRequest and predict_pb2.PredictResponse respectively. E.g.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: