Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request logger metadata lookup #3183

Merged
merged 11 commits into from
May 19, 2021

Conversation

ryandawsonuk
Copy link
Contributor

for #3182

env_api = EnvironmentApi(api_client)
print(env_api.read_user())

#TODO: below isn't working, even though above is (so problem specific to metadata)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works following SeldonIO/seldon-deploy-sdk#20

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@ryandawsonuk: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration bff1250 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ryandawsonuk ryandawsonuk force-pushed the 3182-req-logger-metadata branch from bff1250 to bda2303 Compare May 19, 2021 09:44
Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ryandawsonuk
Copy link
Contributor Author

/retest

Must be some flakiness in the operator tests as this doesn't relate to the operator at all

@ryandawsonuk
Copy link
Contributor Author

Hmm, maybe operator tests are failing now because I rebased from master this morning

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants