-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request logger metadata lookup #3183
request logger metadata lookup #3183
Conversation
env_api = EnvironmentApi(api_client) | ||
print(env_api.read_user()) | ||
|
||
#TODO: below isn't working, even though above is (so problem specific to metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now works following SeldonIO/seldon-deploy-sdk#20
/test integration |
@ryandawsonuk: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
bff1250
to
bda2303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Must be some flakiness in the operator tests as this doesn't relate to the operator at all |
Hmm, maybe operator tests are failing now because I rebased from master this morning |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SachinVarghese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
for #3182