Rclone as default storage initalizer #3159
Conversation
|
/test integration |
|
/test notebooks |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
To note: integration and notebook tests passed in a commit prior to one containing docs changes. |
| - Minio-compatible (using `s3://`) | ||
| - Azure Blob storage (using `https://(.+?).blob.core.windows.net/(.+)`) | ||
|
|
||
| A Kubernetes PersistentVolume [can be used](../examples/pvc-tfjob.html) instead of a bucket using `pvc://`. |
There was a problem hiding this comment.
One thing I am not sure is if this is feature of SC Operator or the kfserving storage initialiser?
| @@ -90,7 +90,7 @@ singleNamespace: false | |||
| storageInitializer: | |||
| cpuLimit: "1" | |||
| cpuRequest: 100m | |||
| image: gcr.io/kfserving/storage-initializer:v0.4.0 | |||
| image: seldonio/rclone-storage-initializer:1.8.0-dev | |||
There was a problem hiding this comment.
Would this be covered by the release.py?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Make rclone storage initializer default in Seldon Core 1.8
Which issue(s) this PR fixes:
Closes #2942
Closes #1028
Special notes for your reviewer:
Does this PR introduce a user-facing change?: