Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to container services for graph internal nodes #3123

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Add label to container services for graph internal nodes #3123

merged 4 commits into from
Apr 30, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Adds labels for internal graph node services so they can easily be found

Which issue(s) this PR fixes:

Fixes #2757

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@SachinVarghese
Copy link
Contributor

@cliveseldon looks good. There was another problem with explainer labels mentioned in the issue where the label seldon-app is followed by a -explainer for deployments, services, and pods. I am not sure if this is desired or what the seldon-app label represents in this case.

@ukclivecox
Copy link
Contributor Author

/test integration

@axsaucedo axsaucedo changed the title Add label to container services for graph internal nodes OSS-244: Add label to container services for graph internal nodes Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-244: Add label to container services for graph internal nodes Add label to container services for graph internal nodes Apr 26, 2021
@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit e81e475 into SeldonIO:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve labelling inconsistencies on seldon-managed k8s resources
4 participants