Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gunicorn to request logger #3121

Merged
merged 1 commit into from
Jun 7, 2021
Merged

add gunicorn to request logger #3121

merged 1 commit into from
Jun 7, 2021

Conversation

rileyhun
Copy link

@rileyhun rileyhun commented Apr 14, 2021

What this PR does / why we need it:
Update request logger with gunicorn

Which issue(s) this PR fixes:

Fixes #2141

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @rileyhun. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@rileyhun
Copy link
Author

/assign @jklaise

@axsaucedo axsaucedo changed the title add gunicorn to request logger OSS-243: add gunicorn to request logger Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-243: add gunicorn to request logger add gunicorn to request logger Apr 26, 2021
@axsaucedo axsaucedo self-requested a review April 27, 2021 06:24
@axsaucedo axsaucedo requested review from ryandawsonuk and removed request for axsaucedo June 3, 2021 10:09
Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Have checked this in kubernetes and all looks good

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit b87004d into SeldonIO:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request logger to run with gunicorn
4 participants