mlflow example fix & image change: do not use editable install of SC for s2i wrapper

[RafalSkolasinski]

Change default bucket for mlflow example. Closes #3124

Modify s2i wrapper images such that Seldon Core is not installed in editable mode.
This is required for compatibility with conda-pack.

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test notebooks

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[axsaucedo]

/test integration

[axsaucedo]

/test notebooks

[axsaucedo]

Seems e2e tests failing were the ones from mlflow server

[axsaucedo]

Only thing to take into consideration is that pip install <path> re-uses any cached pre-built binaries (whereas make install / pip install . doesnt), so quite important to make sure people clear these folders before running the build, otherwise theyh'll be installing the cached version instead of the one from source

[RafalSkolasinski]

Only thing to take into consideration is that pip install <path> re-uses any cached pre-built binaries (whereas make install / pip install . doesnt), so quite important to make sure people clear these folders before running the build, otherwise theyh'll be installing the cached version instead of the one from source

I wasn't aware of pip install . vs pip install <path> difference.

I will change to

RUN cd /microservice/python && pip install .

The main difference I want to achieve is that make install == pip install -e . and I want to get rid of -e flag.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

/test notebooks

[RafalSkolasinski]

Hmm... only lint and docs problem. But integration and notebooks passed!

[RafalSkolasinski]

Just for later reference