Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "appVersion" in helm chart yaml #3113

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

DanielQujun
Copy link
Contributor

FIX #2737

Add "appVersion" in helm chart yaml

Signed-off-by: 屈骏 [email protected]

@seldondev
Copy link
Collaborator

Hi @DanielQujun. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DanielQujun DanielQujun force-pushed the add_appVersion_in_chartyaml branch from 251c3ee to e902d70 Compare April 8, 2021 07:41
@seldondev seldondev added size/XS and removed size/XXL labels Apr 8, 2021
@DanielQujun
Copy link
Contributor Author

/assign @cliveseldon

@axsaucedo axsaucedo changed the title Add "appVersion" in helm chart yaml OSS-239: Add "appVersion" in helm chart yaml Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-239: Add "appVersion" in helm chart yaml Add "appVersion" in helm chart yaml Apr 26, 2021
@axsaucedo axsaucedo self-requested a review August 10, 2021 10:26
@axsaucedo
Copy link
Contributor

Thanks!

@axsaucedo axsaucedo merged commit e580c2a into SeldonIO:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing appVersion inside Chart.yaml
4 participants