Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_data parameter to SeldonClient predict #3095

Merged
merged 6 commits into from
Mar 26, 2021

Conversation

nadinet
Copy link
Contributor

@nadinet nadinet commented Mar 26, 2021

What this PR does / why we need it:
Add raw_data parameter to SeldonClient predict. enable raw payload for REST/gRpc.
Add unit testing and upadate sklearn_iris notebook eample to include raw_data use example.
Which issue(s) this PR fixes:
#3079

Fixes #3079

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

python/seldon_core/seldon_client.py Show resolved Hide resolved
python/tests/test_seldon_client.py Outdated Show resolved Hide resolved
python/tests/test_seldon_client.py Outdated Show resolved Hide resolved
python/tests/test_seldon_client.py Outdated Show resolved Hide resolved
@nadinet nadinet requested a review from adriangonz March 26, 2021 16:04
@axsaucedo
Copy link
Contributor

Looks good
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit be97543 into SeldonIO:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add raw_data parameter to predict / transform / etc functions in Seldon Client
5 participants