Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kustomize patch to include storageInitializerImage in the CRD #3090

Merged
merged 2 commits into from
Mar 24, 2021
Merged

fix kustomize patch to include storageInitializerImage in the CRD #3090

merged 2 commits into from
Mar 24, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Updating graph part of the CRD requires modifying the kustomize patch.
This was forgotten when CRD was extended to allow for storageInitializerImage being defined there.

Which issue(s) this PR fixes:

Fixes #3087

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

2 similar comments
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

Integration test has already passed.

Now pushed a tiny fix to the explainer notebook.
/test notebooks

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit abda015 into SeldonIO:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storageInitializerImage does not work on Kubernetes 1.18
3 participants