Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python server docs #3074

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Update python server docs #3074

merged 1 commit into from
Mar 24, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Fixes outdated python server docs

  • removes protocol argument and --port
  • adds --http-port
  • adds --grpc-port

Which issue(s) this PR fixes:

Fixes #3069

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 9f069ff into SeldonIO:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix python wrapper command line args docs
3 participants