Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integration / notebook tests #3039

Closed
wants to merge 3 commits into from
Closed

fix integration / notebook tests #3039

wants to merge 3 commits into from

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Mar 10, 2021 •
edited
Loading

What this PR does / why we need it:

Pins setuptools in addition to pinned pip.

Which issue(s) this PR fixes:

Fixes #3038

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev added size/M and removed size/XS labels Mar 10, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski RafalSkolasinski changed the title pin pip and setuptools fix integration / notebook tests Mar 10, 2021
@RafalSkolasinski
Copy link
Contributor Author

one notebook failure
/test notebooks

@axsaucedo axsaucedo requested a review from ukclivecox March 10, 2021 21:34
@axsaucedo
Copy link
Contributor

Adding @cliveseldon as well for visibility as it reverts the PR - I'm wondering whether it could be related to the core builder requiring updating of controllerbuild

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev seldondev added size/XS and removed size/M labels Mar 11, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev seldondev added size/XL and removed size/XS labels Mar 11, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

Notebooks tests are passing now.

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Mar 12, 2021 •
edited
Loading

In previous two runs of integration tests it were two different tests that failed in each run:

  • TestClusterWide.test_mab_model - due to use of faulty images -> should be fixed now
  • TestTagsPythonS2iK8s.test_model_combiner_grpc - hopefully old good flakiness

Triggered tests again to verify.

@axsaucedo
Copy link
Contributor

Nice @RafalSkolasinski !
image

2 similar comments
@axsaucedo
Copy link
Contributor

Nice @RafalSkolasinski !
image

@axsaucedo
Copy link
Contributor

Nice @RafalSkolasinski !
image

@axsaucedo
Copy link
Contributor

Closing pull requsest as it was already merged via commit adfc6b3, but wasn't registered due to issues with github

@axsaucedo axsaucedo closed this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python microservice refuses to start: setuptools dep conflict
3 participants
@RafalSkolasinski @seldondev @axsaucedo