Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete mutating webhook if exists when operator creates resources #3031

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Delete mutating webhook if exists when operator creates resources #3031

merged 3 commits into from
Mar 15, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Attempts to delete old seldon mutating webhook if exists to cleanup on older version of seldon
    Which issue(s) this PR fixes:

Fixes #3024

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor

/test notebooks

2 similar comments
@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks f6d3ba8 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox
Copy link
Contributor Author

@cliveseldon change function name for clarity to delete MWC

@ukclivecox ukclivecox merged commit 39f5386 into SeldonIO:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mutating Webhook if found in latest operator startup
4 participants