Update health status #3023
Update health status #3023
Conversation
|
Looks good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration |
|
Should we also allow |
Maybe can you create a new issue for this? @ktleung2017 |
#3046 created. |
| @@ -158,6 +158,7 @@ func (r *SeldonRestApi) Initialise() { | |||
| api10.Handle("/predictions", r.wrapMetrics(metric.PredictionHttpServiceName, r.predictions)) | |||
| api10.Handle("/feedback", r.wrapMetrics(metric.FeedbackHttpServiceName, r.feedback)) | |||
| r.Router.NewRoute().Path("/api/v1.0/status/{"+ModelHttpPathVariable+"}").Methods("GET", "OPTIONS").HandlerFunc(r.wrapMetrics(metric.StatusHttpServiceName, r.status)) | |||
| r.Router.NewRoute().Path("/api/v1.0/status").Methods("GET", "OPTIONS").HandlerFunc(r.wrapMetrics(metric.StatusHttpServiceName, r.checkReady)) | |||
There was a problem hiding this comment.
Should be /api/v1.0/health/status?
|
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
What this PR does / why we need it:
/health/statusendpoints./health/statusto be called with no model name in executor and default tocheckReadyWhich issue(s) this PR fixes:
Fixes #3022
Special notes for your reviewer:
Does this PR introduce a user-facing change?: