-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear methods when Gunicorn worker exits #3018
Conversation
/test notebooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Just have a few minor questions, see inlines.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also the lint is failing |
Thanks! This looks great I will test it next week! |
@adriangonz: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Clear the internal Python server metrics when a Gunicorn worker exists. Otherwise, the internal dictionary keeps growing, causing a high memory usage in the server itself and other downstream issues in Prometheus.
Which issue(s) this PR fixes:
Fixes #2873
Special notes for your reviewer:
Only the entries relevant to a worker process will be cleared.
Does this PR introduce a user-facing change?: