Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seldon CRD Status Removal #2941

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Seldon CRD Status Removal #2941

merged 3 commits into from
Feb 17, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2132

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@ukclivecox
Copy link
Contributor Author

/test

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/ok-to-test

@seldondev
Copy link
Collaborator

Thu Feb 11 10:21:54 UTC 2021
The logs for [integration] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2941/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2941 --build=1

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Feb 11 10:24:16 UTC 2021
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2941/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2941 --build=2

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Feb 12 08:32:39 UTC 2021
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2941/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2941 --build=3

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev seldondev removed the lgtm label Feb 17, 2021
@seldondev
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-valkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 1c53b7a into SeldonIO:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Status section of generated CRD by kubebuilder
3 participants