Add more deps to cover whitebox TreeShap explainers #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cliveseldon @jklaise @RafalSkolasinski |
|
/approve LGTM. Agree with being more flexible in the future, even with different versions of the same libraries that users may want to specify instead. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklaise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
catboostandlightgbmas extra dependencies of the image. The overall size doesn't increase by that much (around 200MBs).This PR also includes some changes that make the overall image a bit smaller than before.
Which issue(s) this PR fixes:
Fixes #2812
Special notes for your reviewer:
Note that this PR doesn't fully address the issue. As
alibievolves, the list of dependencies would need to keep growing. However, it's a simple enough short-term workaround which includes the most common GBT frameworks.On the longer term, we are exploring a better solution from the MLServer side (SeldonIO/MLServer#123) which would allow users to specify custom environments on their explainers. This could be leveraged to match the training and production environments up to the exact library version.
Does this PR introduce a user-facing change?: