Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary metrics to executor #2922

Merged
merged 5 commits into from
Feb 5, 2021
Merged

Add summary metrics to executor #2922

merged 5 commits into from
Feb 5, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:
Adds #2895 on master.
Solves #2765 on master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RafalSkolasinski RafalSkolasinski marked this pull request as draft February 3, 2021 14:48
@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Wed Feb 3 17:38:30 UTC 2021
The logs for [notebooks] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=1

@seldondev
Copy link
Collaborator

Wed Feb 3 17:38:44 UTC 2021
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=2

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Wed Feb 3 17:49:57 UTC 2021
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=3

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Feb 3 18:12:04 UTC 2021
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=4

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Feb 4 10:11:45 UTC 2021
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=5

@RafalSkolasinski
Copy link
Contributor Author

Notebooks and integrations passed in previous runs, repeating for completness.
/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Thu Feb 4 13:23:32 UTC 2021
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=6

@seldondev
Copy link
Collaborator

Thu Feb 4 13:23:45 UTC 2021
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2922/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2922 --build=7

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review February 4, 2021 15:44
@RafalSkolasinski
Copy link
Contributor Author

Same as #2895 this one is ready to land. All checks are green.

@axsaucedo
Copy link
Contributor

Looks good! On this one that will go to master would be good to add further docs on the metrics page

@RafalSkolasinski
Copy link
Contributor Author

Looks good! On this one that will go to master would be good to add further docs on the metrics page

Good idea, though, shall maybe follow on separate PR so we don't loose the "all green" status?

@axsaucedo
Copy link
Contributor

@RafalSkolasinski probably best to do it together to make sure it doesn't slip.

For explicitness we can keep confirmation that all integration tests passed:
image

@RafalSkolasinski
Copy link
Contributor Author

Updated doc page
image

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit 23eced9 into SeldonIO:master Feb 5, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants