-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary metrics to executor #2922
Add summary metrics to executor #2922
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test notebooks |
Wed Feb 3 17:38:30 UTC 2021 impatient try |
Wed Feb 3 17:38:44 UTC 2021 impatient try |
/test notebooks |
Wed Feb 3 17:49:57 UTC 2021 impatient try |
/test integration |
Wed Feb 3 18:12:04 UTC 2021 impatient try |
/test integration |
Thu Feb 4 10:11:45 UTC 2021 impatient try |
Notebooks and integrations passed in previous runs, repeating for completness. |
Thu Feb 4 13:23:32 UTC 2021 impatient try |
Thu Feb 4 13:23:45 UTC 2021 impatient try |
Same as #2895 this one is ready to land. All checks are green. |
Looks good! On this one that will go to |
Good idea, though, shall maybe follow on separate PR so we don't loose the "all green" status? |
@RafalSkolasinski probably best to do it together to make sure it doesn't slip. For explicitness we can keep confirmation that all integration tests passed: |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds #2895 on master.
Solves #2765 on master.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: