Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpcPort and httpPort in v1 CRD #2868

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix grpcPort and httpPort in v1 CRD #2868

merged 1 commit into from
Jan 22, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Fixes the V1 CRD (k8s >= 1.18) which was missing grpcPort and httpPort in OpenAPISchema in CRD definition.
  • Fixes protocol_examples notebook which had old grpc_port in example

Which issue(s) this PR fixes:

Fixes #2866

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo January 22, 2021 10:28
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 22 10:29:33 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2868/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2868 --build=2

@seldondev
Copy link
Collaborator

Fri Jan 22 10:29:38 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2868/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2868 --build=1

@axsaucedo axsaucedo merged commit 6f92a87 into SeldonIO:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1 CRD has missing grpcPort and httpPort
3 participants