-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Seldon versions for upgrade tests #2861
Update Seldon versions for upgrade tests #2861
Conversation
/test integration |
Thu Jan 21 11:49:06 UTC 2021 impatient try |
Thu Jan 21 11:49:12 UTC 2021 impatient try |
Thu Jan 21 11:51:04 UTC 2021 impatient try |
Fri Jan 22 10:10:42 UTC 2021 impatient try |
Fri Jan 22 10:10:54 UTC 2021 impatient try |
/test integration |
Fri Jan 22 14:02:23 UTC 2021 impatient try |
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
@adriangonz integration test seems to fail on the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Update the lists of Seldon Core versions that are tested for upgrades. To clarify, these tests validate that these upgrade paths work:
1.0.2
->master
1.1.0
->master
1.2.3
->master
1.3.0
->master
1.4.0
->master
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR will make the integration tests a bit longer. It's not clear whether we should test for all direct upgrade paths from
1.0
onwards though. Would be great to hear other people's thoughts.Does this PR introduce a user-facing change?: