Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Seldon versions for upgrade tests #2861

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jan 21, 2021

What this PR does / why we need it:

Update the lists of Seldon Core versions that are tested for upgrades. To clarify, these tests validate that these upgrade paths work:

  • 1.0.2 -> master
  • 1.1.0 -> master
  • 1.2.3 -> master
  • 1.3.0 -> master
  • 1.4.0 -> master

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR will make the integration tests a bit longer. It's not clear whether we should test for all direct upgrade paths from 1.0 onwards though. Would be great to hear other people's thoughts.

Does this PR introduce a user-facing change?:

NONE

@adriangonz
Copy link
Contributor Author

/test integration
/cc @cliveseldon @axsaucedo

@seldondev
Copy link
Collaborator

Thu Jan 21 11:49:06 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=2

@seldondev
Copy link
Collaborator

Thu Jan 21 11:49:12 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=1

@seldondev
Copy link
Collaborator

Thu Jan 21 11:51:04 UTC 2021
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=3

@seldondev seldondev added size/XL and removed size/S labels Jan 22, 2021
@seldondev
Copy link
Collaborator

Fri Jan 22 10:10:42 UTC 2021
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=5

@seldondev
Copy link
Collaborator

Fri Jan 22 10:10:54 UTC 2021
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=4

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Jan 22 14:02:23 UTC 2021
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2861/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2861 --build=6

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 9f63907 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

@adriangonz integration test seems to fail on the test_combiner, which from the previous test seems flaky. May be worth adding an issue if we see this test_combiner test fail again
/approve

@axsaucedo axsaucedo merged commit cf84199 into SeldonIO:master Jan 26, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants