remove mutating webhook from Seldon Core Operator #2852

RafalSkolasinski · 2021-01-18T18:52:24Z

What this PR does / why we need it:

This removes the mutating webhook: Mutatingwebhookconfigurations is not installed into the cluster.
From now on, the SeldonDeployment resource written to etcd of k8s will be exactly the same as resource applied by the user.

This will simplify GitOps operations as the parity between applied and visible resources will be present.
To see extra information that was written into CR before one can take a look at the generated deployments.
They will contain all information about the assigned ports, init containers, etc.

Which issue(s) this PR fixes:

Closes #2817
Closes #2811

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Mutating Webhook is removed. `SeldonDeployment` Resource is written to `etcd` without any alterations.

seldondev · 2021-01-18T18:53:56Z

Mon Jan 18 18:53:55 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=2

seldondev · 2021-01-18T18:54:12Z

Mon Jan 18 18:54:11 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=1

seldondev · 2021-01-18T18:57:05Z

Mon Jan 18 18:57:03 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=3

seldondev · 2021-01-18T18:57:18Z

Mon Jan 18 18:57:16 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=4

seldondev · 2021-01-18T18:59:27Z

Mon Jan 18 18:59:25 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=5

seldondev · 2021-01-18T18:59:33Z

Mon Jan 18 18:59:32 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=6

RafalSkolasinski · 2021-01-19T10:37:12Z

/test integration
/test notebooks

seldondev · 2021-01-19T10:38:45Z

Tue Jan 19 10:38:43 UTC 2021
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=8

seldondev · 2021-01-19T10:38:45Z

Tue Jan 19 10:38:42 UTC 2021
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=10

seldondev · 2021-01-19T10:38:45Z

Tue Jan 19 10:38:40 UTC 2021
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=7

seldondev · 2021-01-19T10:38:50Z

Tue Jan 19 10:38:48 UTC 2021
The logs for [notebooks] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=9

axsaucedo · 2021-01-19T11:00:39Z

operator/apis/machinelearning.seldon.io/v1/seldondeployment_webhook.go

@@ -540,18 +547,6 @@ func (r *SeldonDeploymentSpec) ValidateSeldonDeployment() error {

 // EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!

-// +kubebuilder:webhook:path=/mutate-machinelearning-seldon-io-v1-seldondeployment,mutating=true,failurePolicy=fail,sideEffects=None,groups=machinelearning.seldon.io,resources=seldondeployments,verbs=create;update,versions=v1,name=v1.mseldondeployment.kb.io


All the code related to the webhook should be removed as well, as there are several functions in this file which would no longer be called

We need to keep the mutating functionality which is called from Reconcile

Ok makes sense, although it woudl still be worth moving it from the webhook file as it would no longer be used by the webhook itself

Actually the code will be required in the webhooks -> validating webhooks were receiving defaulted resource before.
Now they need to apply defaulting on their own before validating -> I suspect that was the reason why tests failed in previous run.

It is now moved into a file containing actual types.

RafalSkolasinski · 2021-01-19T11:20:30Z

Seems integration tests are not going well

23 failed, 12 passed

gonna have to look locally into them

seldondev · 2021-01-19T12:03:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RafalSkolasinski · 2021-01-19T12:03:47Z

Let's hope it is fixed now.
/test integration

seldondev · 2021-01-19T12:04:03Z

Tue Jan 19 12:04:01 UTC 2021
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=12

seldondev · 2021-01-19T12:04:08Z

Tue Jan 19 12:04:05 UTC 2021
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=11

seldondev · 2021-01-19T12:06:40Z

Tue Jan 19 12:06:38 UTC 2021
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=13

RafalSkolasinski · 2021-01-19T15:10:42Z

Only 13 failures now...

RafalSkolasinski · 2021-01-19T15:46:04Z

/test integration

seldondev · 2021-01-19T15:47:31Z

Tue Jan 19 15:47:26 UTC 2021
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=14

seldondev · 2021-01-19T15:47:41Z

Tue Jan 19 15:47:40 UTC 2021
The logs for [integration] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=16

seldondev · 2021-01-19T15:47:44Z

Tue Jan 19 15:47:43 UTC 2021
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=15

seldondev · 2021-01-22T12:10:21Z

Fri Jan 22 12:10:19 UTC 2021
The logs for [integration] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=30

RafalSkolasinski · 2021-01-22T14:08:50Z

had to rebase on master
/test integration
/test notebooks

seldondev · 2021-01-22T14:10:27Z

Fri Jan 22 14:10:26 UTC 2021
The logs for [integration] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=34

seldondev · 2021-01-22T14:10:28Z

Fri Jan 22 14:10:27 UTC 2021
The logs for [lint] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=32

seldondev · 2021-01-22T14:10:36Z

Fri Jan 22 14:10:35 UTC 2021
The logs for [notebooks] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=33

seldondev · 2021-01-22T14:10:38Z

Fri Jan 22 14:10:37 UTC 2021
The logs for [pr-build] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=31

RafalSkolasinski · 2021-01-22T18:13:21Z

/retest

seldondev · 2021-01-22T18:14:57Z

Fri Jan 22 18:14:53 UTC 2021
The logs for [integration] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=35

RafalSkolasinski · 2021-01-22T20:41:16Z

something had to go wrong during rebase, gonna fix on Monday

RafalSkolasinski · 2021-01-22T20:41:19Z

/retest

seldondev · 2021-01-22T20:42:47Z

Fri Jan 22 20:42:46 UTC 2021
The logs for [integration] [36] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/36.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=36

RafalSkolasinski · 2021-01-23T17:12:41Z

/retest

seldondev · 2021-01-23T17:14:23Z

Sat Jan 23 17:14:22 UTC 2021
The logs for [integration] [37] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/37.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=37

RafalSkolasinski · 2021-01-25T09:39:41Z

/retest

seldondev · 2021-01-25T09:41:05Z

Mon Jan 25 09:41:04 UTC 2021
The logs for [integration] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=38

RafalSkolasinski · 2021-01-26T13:29:37Z

~~currently blocked by #2886, need to be rebased once #2886 is merged~~

unblocked

RafalSkolasinski · 2021-01-26T14:00:50Z

/test integration
/test notebooks

seldondev · 2021-01-26T14:01:10Z

Tue Jan 26 14:01:07 UTC 2021
The logs for [lint] [40] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/40.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=40

seldondev · 2021-01-26T14:01:24Z

Tue Jan 26 14:01:22 UTC 2021
The logs for [pr-build] [39] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/39.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=39

seldondev · 2021-01-26T14:02:49Z

Tue Jan 26 14:02:48 UTC 2021
The logs for [integration] [42] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/42.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=42

seldondev · 2021-01-26T14:03:01Z

Tue Jan 26 14:02:59 UTC 2021
The logs for [notebooks] [41] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/41.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=41

RafalSkolasinski · 2021-01-26T14:10:54Z

Rebased onto master, nicely squashed commit and also tested once again locally that mutatingwebhook is not getting created.
Running tests in CI - should be good to merge after.

@cliveseldon, don't know if you want to have a final look over the changes?

RafalSkolasinski · 2021-01-26T15:05:18Z

Hmm... notebook tests failed on installation of istio

✘ Addons encountered an error: failed to wait for resource: resources not ready after 5m0s: timed out waiting for the condition
Deployment/istio-system/grafana
- Pruning removed resourcesError: failed to apply manifests: errors occurred during operation
make: *** [Makefile:107: install_istio] Error 1
Kind setup returned errors

/retest

seldondev · 2021-01-26T15:08:53Z

Tue Jan 26 15:08:49 UTC 2021
The logs for [notebooks] [43] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/43.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=43

RafalSkolasinski · 2021-01-26T16:39:46Z

/retest

seldondev · 2021-01-26T16:41:32Z

Tue Jan 26 16:41:28 UTC 2021
The logs for [notebooks] [44] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2852/44.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2852 --build=44

RafalSkolasinski · 2021-01-26T18:54:15Z

All testes passed!!! Let's land this 🚀

axsaucedo · 2021-01-26T20:32:46Z

Nice one

seldondev added the size/XXL label Jan 18, 2021

RafalSkolasinski marked this pull request as draft January 18, 2021 18:52

RafalSkolasinski changed the title ~~initial attempt to remove mutating webhook~~ remove mutating webhook from Seldon Core Operator Jan 19, 2021

seldondev added the do-not-merge/work-in-progress label Jan 19, 2021

RafalSkolasinski marked this pull request as ready for review January 19, 2021 10:46

seldondev removed the do-not-merge/work-in-progress label Jan 19, 2021

axsaucedo suggested changes Jan 19, 2021

View reviewed changes

seldondev assigned axsaucedo Jan 19, 2021

remove mutating webhook from Seldon Core Operator

1e43cc8

axsaucedo merged commit fbf7a77 into SeldonIO:master Jan 26, 2021

		@@ -540,18 +547,6 @@ func (r *SeldonDeploymentSpec) ValidateSeldonDeployment() error {

		// EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!

		// +kubebuilder:webhook:path=/mutate-machinelearning-seldon-io-v1-seldondeployment,mutating=true,failurePolicy=fail,sideEffects=None,groups=machinelearning.seldon.io,resources=seldondeployments,verbs=create;update,versions=v1,name=v1.mseldondeployment.kb.io

remove mutating webhook from Seldon Core Operator #2852

remove mutating webhook from Seldon Core Operator #2852

Conversation

RafalSkolasinski commented Jan 18, 2021 • edited Loading

seldondev commented Jan 18, 2021

seldondev commented Jan 18, 2021

seldondev commented Jan 18, 2021

seldondev commented Jan 18, 2021

seldondev commented Jan 18, 2021

seldondev commented Jan 18, 2021

RafalSkolasinski commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

axsaucedo Jan 19, 2021

Choose a reason for hiding this comment

ukclivecox Jan 19, 2021

Choose a reason for hiding this comment

axsaucedo Jan 19, 2021

Choose a reason for hiding this comment

RafalSkolasinski Jan 19, 2021

Choose a reason for hiding this comment

RafalSkolasinski Jan 21, 2021

Choose a reason for hiding this comment

RafalSkolasinski commented Jan 19, 2021

seldondev commented Jan 19, 2021

RafalSkolasinski commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

RafalSkolasinski commented Jan 19, 2021

RafalSkolasinski commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 19, 2021

seldondev commented Jan 22, 2021

RafalSkolasinski commented Jan 22, 2021

seldondev commented Jan 22, 2021

seldondev commented Jan 22, 2021

seldondev commented Jan 22, 2021

seldondev commented Jan 22, 2021

RafalSkolasinski commented Jan 22, 2021

seldondev commented Jan 22, 2021

RafalSkolasinski commented Jan 22, 2021

RafalSkolasinski commented Jan 22, 2021

seldondev commented Jan 22, 2021

RafalSkolasinski commented Jan 23, 2021

seldondev commented Jan 23, 2021

RafalSkolasinski commented Jan 25, 2021

seldondev commented Jan 25, 2021

RafalSkolasinski commented Jan 26, 2021 • edited Loading

RafalSkolasinski commented Jan 26, 2021

seldondev commented Jan 26, 2021

seldondev commented Jan 26, 2021

seldondev commented Jan 26, 2021

seldondev commented Jan 26, 2021

RafalSkolasinski commented Jan 26, 2021

RafalSkolasinski commented Jan 26, 2021

seldondev commented Jan 26, 2021

RafalSkolasinski commented Jan 26, 2021

seldondev commented Jan 26, 2021

RafalSkolasinski commented Jan 26, 2021

axsaucedo commented Jan 26, 2021

RafalSkolasinski commented Jan 18, 2021 •

edited

Loading

RafalSkolasinski commented Jan 26, 2021 •

edited

Loading