-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart repo fix for integration tests #2809
Conversation
/test integration |
Tue Dec 29 10:39:42 UTC 2020 impatient try |
Tue Dec 29 10:39:45 UTC 2020 impatient try |
Tue Dec 29 10:39:55 UTC 2020 impatient try |
@cliveseldon all integration tests pass, before running notebook tests we'd have to fix the KEDA notebook one, I might try to add this in this PR actually as it would be important to get notebooks tests working as well |
Ok added the fix that worked in my local computer, it seems that the initial setup actually creates KEDA pods on the default install, which seem to clash with the /test notebooks |
Tue Dec 29 12:26:57 UTC 2020 impatient try |
Tue Dec 29 12:26:58 UTC 2020 impatient try |
Tue Dec 29 12:27:59 UTC 2020 impatient try |
Ok it seems the last fix addressed the KEDA tests, they are no longer locking, it seems there is another issue in the resources - it seems that the seldon_model files are referencing non-existent images (i.e. currently pointing to /test notebooks |
Tue Dec 29 13:53:01 UTC 2020 impatient try |
Tue Dec 29 13:53:10 UTC 2020 impatient try |
Tue Dec 29 13:55:20 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Dec 29 15:49:52 UTC 2020 impatient try |
Tue Dec 29 15:50:05 UTC 2020 impatient try |
Fixes #2808