Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart repo fix for integration tests #2809

Merged
merged 4 commits into from
Dec 29, 2020

Conversation

axsaucedo
Copy link
Contributor

Fixes #2808

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Dec 29 10:39:42 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=1

@seldondev
Copy link
Collaborator

Tue Dec 29 10:39:45 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=2

@seldondev
Copy link
Collaborator

Tue Dec 29 10:39:55 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=3

@axsaucedo
Copy link
Contributor Author

@cliveseldon all integration tests pass, before running notebook tests we'd have to fix the KEDA notebook one, I might try to add this in this PR actually as it would be important to get notebooks tests working as well

@axsaucedo
Copy link
Contributor Author

Ok added the fix that worked in my local computer, it seems that the initial setup actually creates KEDA pods on the default install, which seem to clash with the kubectl apply ...keda... in the notebook, but also seems to be fixed with the initial kubectl delete....

/test notebooks

@seldondev
Copy link
Collaborator

Tue Dec 29 12:26:57 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=5

@seldondev
Copy link
Collaborator

Tue Dec 29 12:26:58 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=4

@seldondev
Copy link
Collaborator

Tue Dec 29 12:27:59 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=6

@seldondev seldondev added size/S and removed size/XS labels Dec 29, 2020
@axsaucedo
Copy link
Contributor Author

Ok it seems the last fix addressed the KEDA tests, they are no longer locking, it seems there is another issue in the resources - it seems that the seldon_model files are referencing non-existent images (i.e. currently pointing to mock_classifier:1.3.0-dev which doesn't exist). I have now updated it, so will rerun notebooks tests again.

/test notebooks

@seldondev
Copy link
Collaborator

Tue Dec 29 13:53:01 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=7

@seldondev
Copy link
Collaborator

Tue Dec 29 13:53:10 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=8

@seldondev
Copy link
Collaborator

Tue Dec 29 13:55:20 UTC 2020
The logs for [notebooks] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=9

@ukclivecox
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor Author

All notebook tests pass, should be good to merge.

image

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Dec 29 15:49:52 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=10

@seldondev
Copy link
Collaborator

Tue Dec 29 15:50:05 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2809/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2809 --build=11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm failing to fetch https://kubernetes-charts.storage.googleapis.com/ resulting in failing tests
3 participants