-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update request logger to support v2 protocol #2802
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Dec 23 14:50:22 UTC 2020 impatient try |
Wed Dec 23 14:50:43 UTC 2020 impatient try |
copy["dataType"] = "tabular" | ||
else: | ||
copy["dataType"] = "image" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just comparing this logic to https://github.com/SeldonIO/seldon-core/blob/master/components/seldon-request-logger/app/default_logger.py#L314
In that logic 3 dimensions would be batch tabular. Has me wondering about the assumption there that the first dimension is batch.
Tue Jan 5 15:57:15 UTC 2021 impatient try |
Tue Jan 5 15:57:24 UTC 2021 impatient try |
BYTES data fails. But we could leave this until we have a use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2791
Special notes for your reviewer:
Does this PR introduce a user-facing change?: