Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request logger to support v2 protocol #2802

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Update request logger to support v2 protocol #2802

merged 2 commits into from
Jan 6, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Support the V2 protocol in the request logger

Which issue(s) this PR fixes:

Fixes #2791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Dec 23 14:50:22 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2802/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2802 --build=2

@seldondev
Copy link
Collaborator

Wed Dec 23 14:50:43 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2802/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2802 --build=1

copy["dataType"] = "tabular"
else:
copy["dataType"] = "image"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comparing this logic to https://github.com/SeldonIO/seldon-core/blob/master/components/seldon-request-logger/app/default_logger.py#L314
In that logic 3 dimensions would be batch tabular. Has me wondering about the assumption there that the first dimension is batch.

@seldondev
Copy link
Collaborator

Tue Jan 5 15:57:15 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2802/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2802 --build=3

@seldondev
Copy link
Collaborator

Tue Jan 5 15:57:24 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2802/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2802 --build=4

@ukclivecox
Copy link
Contributor Author

BYTES data fails. But we could leave this until we have a use case.

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ukclivecox ukclivecox merged commit 8a180c5 into SeldonIO:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle KFServing V2 Protocol in request logger
3 participants