-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Alibi Detect Server to expose prometheus metrics for outliers #2770
Conversation
Sat Dec 12 13:50:40 UTC 2020 impatient try |
Sat Dec 12 13:50:48 UTC 2020 impatient try |
Mon Dec 14 09:29:17 UTC 2020 impatient try |
Mon Dec 14 09:29:25 UTC 2020 impatient try |
@cliveseldon do you think we still want this or should we close PR? |
@axsaucedo What's the reason to not have it anymore? |
Just to confirm, mainly as we don't currently have a "default dashboard" for it, but I think it would still be worth having actually. Ok - I will fix the lint by rebasing. |
6e9b489
to
730ea86
Compare
Mon Jan 4 16:49:08 UTC 2021 impatient try |
Mon Jan 4 16:49:25 UTC 2021 impatient try |
Seems failed on executor test (which is unrelated to pr), have seen this before if too many jx tests are building the golang binary at the same time |
Mon Jan 4 17:14:32 UTC 2021 impatient try |
Ok cool, should be good to review @cliveseldon |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following the same structure as with the Alibi Drift implementation, exposing metrics for the outlier detector component which could enable simpler visualisation of outliers.