Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Alibi Detect Server to expose prometheus metrics for outliers #2770

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

axsaucedo
Copy link
Contributor

Following the same structure as with the Alibi Drift implementation, exposing metrics for the outlier detector component which could enable simpler visualisation of outliers.

@axsaucedo axsaucedo added this to the 1.6 milestone Dec 12, 2020
@seldondev
Copy link
Collaborator

Sat Dec 12 13:50:40 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=2

@seldondev
Copy link
Collaborator

Sat Dec 12 13:50:48 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=1

@seldondev
Copy link
Collaborator

Mon Dec 14 09:29:17 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=3

@seldondev
Copy link
Collaborator

Mon Dec 14 09:29:25 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=4

@axsaucedo
Copy link
Contributor Author

@cliveseldon do you think we still want this or should we close PR?

@ukclivecox
Copy link
Contributor

@axsaucedo What's the reason to not have it anymore?

@axsaucedo
Copy link
Contributor Author

Just to confirm, mainly as we don't currently have a "default dashboard" for it, but I think it would still be worth having actually. Ok - I will fix the lint by rebasing.

@axsaucedo axsaucedo force-pushed the outlier_added_metrics branch from 6e9b489 to 730ea86 Compare January 4, 2021 16:47
@seldondev
Copy link
Collaborator

Mon Jan 4 16:49:08 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=5

@seldondev
Copy link
Collaborator

Mon Jan 4 16:49:25 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=6

@axsaucedo
Copy link
Contributor Author

Seems failed on executor test (which is unrelated to pr), have seen this before if too many jx tests are building the golang binary at the same time
/test this

@seldondev
Copy link
Collaborator

Mon Jan 4 17:14:32 UTC 2021
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2770/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2770 --build=7

@axsaucedo axsaucedo requested a review from ukclivecox January 4, 2021 17:38
@axsaucedo
Copy link
Contributor Author

Ok cool, should be good to review @cliveseldon

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit ff3816e into SeldonIO:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants