Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples/pachyderm-simple): Update and improve Pachyderm example #2764

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

philwinder
Copy link
Contributor

This PR updates and improves the current pachyderm integration demo. This demo highlights the use of Pachyderm's S3 gateway and how seldon-core deployments can read directly from a version-controlled model artefact.

More sophisticated demos will come next.

What this PR does / why we need it:
Update Pachyderm demo.

Special notes for your reviewer:
This demo requires a public docker image to be built and pushed to seldonio's docker hub (following on from how the previous demo worked).

Someone with access to seldonio's docker hub account needs to:

# login to docker hub then...
cd examples/pachyderm-simple/iris-train-python-svm/
make build
make push

This will push a new version of the already existing training image to here: https://hub.docker.com/r/seldonio/pachyderm-iris-trainer

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @philwinder. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@philwinder
Copy link
Contributor Author

/assign @SachinVarghese

@RafalSkolasinski
Copy link
Contributor

/retest

@RafalSkolasinski RafalSkolasinski added this to the 1.6 milestone Dec 16, 2020
@seldondev
Copy link
Collaborator

Wed Dec 16 12:15:57 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2764/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2764 --build=2

@seldondev
Copy link
Collaborator

Wed Dec 16 12:15:58 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2764/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2764 --build=1

@RafalSkolasinski RafalSkolasinski self-requested a review December 16, 2020 13:49
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @philwinder!

Few comments, it would be good to:

  • use seldon namespace for deployments to be consistent with most of the examples we have
  • add one more kubectl rollout status before sending requests to updated deployment at the end of the notebook

I also noticed that the docs don't build, you may need to update path in https://github.com/SeldonIO/seldon-core/blob/master/doc/source/examples/pachyderm.nblink
to be

"path": "../../../examples/pachyderm-simple/index.ipynb"

It may be required to copy images to doc/source/examples wherever required.
You may build docs locally to test it by using

make livehtml

in the doc directory

@philwinder
Copy link
Contributor Author

Hi @RafalSkolasinski.
I have fixed the docs build, added the extra rollout status check, and moved the deployments to the seldon workspace.

Thanks, Phil

@RafalSkolasinski
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Tue Jan 5 14:38:17 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2764/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2764 --build=4

@seldondev
Copy link
Collaborator

Tue Jan 5 14:38:29 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2764/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2764 --build=3

@RafalSkolasinski
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit c8b47e1 into SeldonIO:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants