-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples/pachyderm-simple): Update and improve Pachyderm example #2764
Conversation
… to use S3 gateway
Hi @philwinder. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/assign @SachinVarghese |
/retest |
Wed Dec 16 12:15:57 UTC 2020 impatient try |
Wed Dec 16 12:15:58 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @philwinder!
Few comments, it would be good to:
- use
seldon
namespace for deployments to be consistent with most of the examples we have - add one more
kubectl rollout status
before sending requests to updated deployment at the end of the notebook
I also noticed that the docs don't build, you may need to update path in https://github.com/SeldonIO/seldon-core/blob/master/doc/source/examples/pachyderm.nblink
to be
"path": "../../../examples/pachyderm-simple/index.ipynb"
It may be required to copy images to doc/source/examples
wherever required.
You may build docs locally to test it by using
make livehtml
in the doc
directory
Hi @RafalSkolasinski. Thanks, Phil |
/ok-to-test |
Tue Jan 5 14:38:17 UTC 2021 impatient try |
Tue Jan 5 14:38:29 UTC 2021 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates and improves the current pachyderm integration demo. This demo highlights the use of Pachyderm's S3 gateway and how seldon-core deployments can read directly from a version-controlled model artefact.
More sophisticated demos will come next.
What this PR does / why we need it:
Update Pachyderm demo.
Special notes for your reviewer:
This demo requires a public docker image to be built and pushed to seldonio's docker hub (following on from how the previous demo worked).
Someone with access to seldonio's docker hub account needs to:
This will push a new version of the already existing training image to here: https://hub.docker.com/r/seldonio/pachyderm-iris-trainer
Does this PR introduce a user-facing change?: