Add pidfile config for gunicorn

[anggao]

What this PR does / why we need it:

Right now we are configuring auto reload for gunicorn, it seems useful to add a pidfile config for gunicorn, so we can refer the master process easily

Which issue(s) this PR fixes:

Fixes #2546

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[seldondev]

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[axsaucedo]

Thank you for the contribution @anggao - very interesting! Could you add a line in the docs section here: https://docs.seldon.io/projects/seldon-core/en/latest/python/python_server.html#configuration

/ok-to-test

[anggao]

sure will do!

[seldondev]

Wed Oct 14 15:33:30 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=1

[seldondev]

Wed Oct 14 15:33:51 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=2

[seldondev]

Wed Oct 14 15:40:31 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=4

[seldondev]

Wed Oct 14 15:40:46 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=3

[axsaucedo]

@anggao you'll have to run rebase and make license in the python/ folder to ensure the lint checks pass

[anggao]

@axsaucedo Yeah I always forgot that :)

[anggao]

/retest

[axsaucedo]

Thanks! This is one we've been thinking of potentially adding to the github actions, so we coudl just run something like /rebuild-license to have this done in the background..

[seldondev]

Wed Oct 14 15:48:44 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=5

[seldondev]

Wed Oct 14 15:48:56 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=6

[seldondev]

Wed Oct 14 15:49:23 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=7

[seldondev]

Wed Oct 14 15:49:51 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=8

[anggao]

@axsaucedo that's would be great or add some git hooks to prevent commit works as well

[axsaucedo]

/test lint

[seldondev]

Wed Oct 14 16:03:45 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=9

[axsaucedo]

/test this

[axsaucedo]

@anggao it seems that the lint is actually failing because black is running and finding a file that would have to be formatted - we actually do have a pre-commithook for this, do you have this configured?

[seldondev]

Wed Oct 14 16:16:06 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=10

[anggao]

@axsaucedo let me check that

[anggao]

@axsaucedo I found make task fmt is broken, so I fixed it as well and rerun make fmt

[seldondev]

Wed Oct 14 16:30:50 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=11

[seldondev]

Wed Oct 14 16:31:01 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2547/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2547 --build=12

[axsaucedo]

Oh wow, good catch, thanks @anggao !

[axsaucedo]

/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment